Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backspacing over control visualizers #16400

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix backspacing over control visualizers #16400

merged 1 commit into from
Dec 4, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Nov 30, 2023 •
edited
Loading

During !measureOnly the old code would increment distance twice.
Now it doesn't. :)

Closes #16356

Validation Steps Performed

See updated test instructions in doc/COOKED_READ_DATA.md

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-CookedRead The cmd.exe COOKED_READ handling Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase labels Nov 30, 2023
@lhecker lhecker added the zInbox-Bug Ignore me! label Dec 2, 2023
@DHowett DHowett merged commit 654b755 into main Dec 4, 2023
15 of 17 checks passed
@DHowett DHowett deleted the dev/lhecker/16356-cooked-read-fixup branch December 4, 2023 20:14
DHowett pushed a commit that referenced this pull request Dec 4, 2023
@lhecker @DHowett
Fix backspacing over control visualizers (#16400)
e33de75 
During `!measureOnly` the old code would increment `distance` twice.
Now it doesn't. :)

Closes #16356

## Validation Steps Performed
See updated test instructions in `doc/COOKED_READ_DATA.md`

(cherry picked from commit 654b755)
Service-Card-Id: 91232745
Service-Version: 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees
No one assigned
Labels
Area-CookedRead The cmd.exe COOKED_READ handling Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase zInbox-Bug Ignore me!
Projects
1.19 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COOKED_READ: Backspacing over control visualizers (^W) deletes 4 glyphs
3 participants
@lhecker @DHowett @PankajBhojwani